Google Analytics - PHP error with official module

[Yass]

Hello,
 
Following an upgrade to the latest version (2.0.6) we noticed a huge increase for errors and warning in our log files.
 
e.g:
E_WARNING: number_format() expects parameter 1 to be double, string given
…/home/ccc/web/xxx.com/www/http/modules/ganalytics/ganalytics.php (468)
…/home/ccc/web/xxx.com/www/http/modules/ganalytics/ganalytics.php (416)
…/home/ccc/web/xxx.com/www/http/modules/ganalytics/ganalytics.php (312)

 

Are any of you experiencing the same issues with this module ?

 

 

[El Patron]

it's not an error, it's a notice and the php script does not abort.

 

the display_errors can be modified to be 'less' informative, learn more here:

http://php.net/manual/en/function.error-reporting.php

[bellini13]

(Fred, this is not directed at you)

 

This is the type of double standard I am always complaining about with prestashop modules and technical validation.  Prestashop should not be creating and releasing a module that behaves in such a way. 

 

if number_format expects a double/float, then a string should not be passed.  We as contributors are forced to cast or adhere to standards, why is the same not true for them?

[Yass]

I totally agree with you Bellini,

 

This totally go against Prestashop's own coding rules.

 

Regarding the fact of changing the error reporting in PHP this is not really a solution but only a way to hide these errors.

We're using a monitoring software for our website and all the lights turned orange since this update.

[El Patron]

well...again it's not an error.

 

for PrestaShop to review your request, please open a forge 'feature' request.

then post back the link here for others to follow/comment/vote up

http://forge.prestashop.com/