Rigth way to little touch a module php file

[elepwr]

Hello, the thing is that I needed some changes in a module, the blocktopmenu.

 

I have edited some of the code in the blocktopmenu.php file, is this right? Its ok to leave this like that with comments about what I did or should I develop something like a copy of this module?

 

I mean, should I use blocktopmenu(edited by me) or I should have blocktopmenuCustom and leave the original untouched??

[vekia]

I have edited some of the code in the blocktopmenu.php file, is this right?

 

everything depends on what code you added to this module. we don't know what code you use so it's hard to say if this is right, or not.

[elepwr]

I added some css classes to the php file, wich I know its a nono since this should be done in the template file, but I needed to change the way the data was sent to the template.

 

I just added some class="XXX" to the <li> and <ul> elements.

[vekia]

so everything is allright, but remember that after update of this module you will loose these changes, 

if you want to avoid it, you have to change module name