Adam Cameron Posted August 6 Share Posted August 6 (edited) Hi there ========== UPDATE (after I submitted the initial Q, below): I now see that the docker image it's using the `VERSION` for is `https://hub.docker.com/r/prestashop/base`, not `https://hub.docker.com/r/prestashop/prestashop`, so the 8.1 makes sense. I'm just now terribly confused as to what docker image is what, but that's on me to work out! ========== I only started looking at PrestaShop yesterday, and have been fumbling around in the codebase. So far: so good. Being a dev my first port of call was GitHub, and following the guidance in the README.md to get things working via Docker. I ran the docker compose stuff successfully y/day, however I noticed I was on the `develop` branch, and really want to check the latest tagged release, not a development version of the app. So I switched to the 9.0.0 tag, and was about to install when I note that the 9.0.0 branch still uses a 8.1 docker image: ``` args: - VERSION=${VERSION:-8.1-apache} ``` (from https://github.com/PrestaShop/PrestaShop/blob/9.0.0/docker-compose.yml#L26). Obvs I can see that I can override that with my own env var, but was wondering whether this default was intentional, or an oversight on the part of the dev team not updating that before tagging the release (it's the same on develop too, btw)? If it's the latter I'm happy to raise a bug, but didn't want to do that until I understood the situation. I'm a n00b after all 😄 If it's the former... what am I missing? IE: why would a 9.x install use a 8.x docker image (esp as there's a 9.0-apache image on docker hub). Thanks for being patient with a n00b. -- Adam Edited August 6 by Adam Cameron resolving my probable confusion (see edit history) Link to comment Share on other sites More sharing options...
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now