Upgrade 1.6.15 to 1.6.16 fails with error 32

[Sumaleth]

I'm seeing this when I try to run install/upgrade/upgrade.php:

<action result="fail" error="32" />

I can see that the problem comes from this part of upgrade.php:

$neededUpgradeFiles = array();
foreach ($upgradeFiles as $version) {
    if (version_compare($version, $oldversion) == 1 and version_compare(_PS_INSTALL_VERSION_, $version) != -1) {
        $neededUpgradeFiles[] = $version;
    }
}
if (empty($fail_result) && empty($neededUpgradeFiles)) {
    $logger->logError('No upgrade is possible.');
    $fail_result .= '<action result="fail" error="32" />'."\n";
}

Specifically; there has been no earlier fail (empty($fail_result) is true) and there are no needed upgradefiles (empty($neededUpgradeFiles) is true too).

 

So looking closer at the loop that is meant to build $neededUpgradeFiles, I can tell you that these values are set:

$oldversion = 1.6.15
_PS_INSTALL_VERSION_ = 1.6.16

And the loop through $upgradeFiles produces this list of $version values along with the two version_compare() results:

0.9 -1 and 1
0.9.1 -1 and 1
0.9.1.2 -1 and 1
0.9.5.1 -1 and 1
0.9.5.2 -1 and 1
0.9.6.1 -1 and 1
0.9.6.2 -1 and 1
0.9.7.1 -1 and 1
0.9.7.2 -1 and 1
1.0.0.1 -1 and 1
1.0.0.2 -1 and 1
1.0.0.3 -1 and 1
1.0.0.4 -1 and 1
1.0.0.5 -1 and 1
1.0.0.6 -1 and 1
1.0.0.7 -1 and 1
1.0.0.8 -1 and 1
1.1.0.1 -1 and 1
1.1.0.2 -1 and 1
1.1.0.3 -1 and 1
1.1.0.4 -1 and 1
1.1.0.5 -1 and 1
1.2.0.1 -1 and 1
1.2.0.2 -1 and 1
1.2.0.3 -1 and 1
1.2.0.4 -1 and 1
1.2.0.5 -1 and 1
1.2.0.6 -1 and 1
1.2.0.7 -1 and 1
1.2.0.8 -1 and 1
1.2.1.0 -1 and 1
1.2.2.0 -1 and 1
1.2.3.0 -1 and 1
1.2.4.0 -1 and 1
1.2.5.0 -1 and 1
1.3.0.1 -1 and 1
1.3.0.2 -1 and 1
1.3.0.3 -1 and 1
1.3.0.4 -1 and 1
1.3.0.5 -1 and 1
1.3.0.6 -1 and 1
1.3.0.7 -1 and 1
1.3.0.8 -1 and 1
1.3.0.9 -1 and 1
1.3.0.10 -1 and 1
1.3.1.1 -1 and 1
1.3.2.1 -1 and 1
1.3.2.2 -1 and 1
1.3.2.3 -1 and 1
1.3.3.0 -1 and 1
1.3.4.0 -1 and 1
1.3.5.0 -1 and 1
1.3.6.0 -1 and 1
1.3.7.0 -1 and 1
1.4.0.1 -1 and 1
1.4.0.2 -1 and 1
1.4.0.3 -1 and 1
1.4.0.4 -1 and 1
1.4.0.5 -1 and 1
1.4.0.6 -1 and 1
1.4.0.7 -1 and 1
1.4.0.8 -1 and 1
1.4.0.9 -1 and 1
1.4.0.10 -1 and 1
1.4.0.11 -1 and 1
1.4.0.12 -1 and 1
1.4.0.13 -1 and 1
1.4.0.14 -1 and 1
1.4.0.15 -1 and 1
1.4.0.16 -1 and 1
1.4.0.17 -1 and 1
1.4.1.0 -1 and 1
1.4.2.0 -1 and 1
1.4.2.1 -1 and 1
1.4.2.2 -1 and 1
1.4.2.3 -1 and 1
1.4.2.4 -1 and 1
1.4.2.5 -1 and 1
1.4.3.0 -1 and 1
1.4.4.0 -1 and 1
1.4.4.1 -1 and 1
1.4.5.0 -1 and 1
1.4.5.1 -1 and 1
1.4.6.0 -1 and 1
1.4.6.1 -1 and 1
1.4.6.2 -1 and 1
1.4.7.0 -1 and 1
1.4.7.1 -1 and 1
1.4.7.2 -1 and 1
1.4.8.0 -1 and 1
1.4.9.0 -1 and 1
1.5.0.0 -1 and 1
1.5.0.1 -1 and 1
1.5.0.2 -1 and 1
1.5.0.3 -1 and 1
1.5.0.4 -1 and 1
1.5.0.5 -1 and 1
1.5.0.6 -1 and 1
1.5.0.7 -1 and 1
1.5.0.8 -1 and 1
1.5.0.9 -1 and 1
1.5.0.10 -1 and 1
1.5.0.11 -1 and 1
1.5.0.12 -1 and 1
1.5.0.13 -1 and 1
1.5.0.14 -1 and 1
1.5.0.15 -1 and 1
1.5.0.16 -1 and 1
1.5.0.17 -1 and 1
1.5.1.0 -1 and 1
1.5.2.0 -1 and 1
1.5.3.0 -1 and 1
1.5.3.1 -1 and 1
1.5.4.0 -1 and 1
1.5.4.1 -1 and 1
1.5.5.0 -1 and 1
1.5.6.0 -1 and 1
1.5.6.1 -1 and 1
1.5.6.2 -1 and 1
1.6.0.1 -1 and 1
1.6.0.2 -1 and 1
1.6.0.3 -1 and 1
1.6.0.4 -1 and 1
1.6.0.5 -1 and 1
1.6.0.6 -1 and 1
1.6.0.7 -1 and 1
1.6.0.8 -1 and 1
1.6.0.9 -1 and 1
1.6.0.10 -1 and 1
1.6.0.11 -1 and 1
1.6.0.12 -1 and 1
1.6.1.0 -1 and 1
1.6.1.1 -1 and 1
1.6.1.2 -1 and 1
1.6.1.5 -1 and 1
1.6.1.6 -1 and 1
1.6.1.7 -1 and 1
1.6.1.11 -1 and 1
1.6.1.13 -1 and 1
1.6.1.14 -1 and 1
index.php -1 and 1

So, the problem is that there are no "upgradeFiles" that are newer than the "oldversion". And if that list of upgradeFiles comes from here:

./install/upgrade/sql/

Then yes, the files only go up to 1.6.1.14.

 

Should there be a file for 1.6.1.16? Feels like there should be a 1.6.1.16 file that at least sets the new version in the database, but I might be wrong.

 

I'd love some thoughts. Thanks.

 

Rowan

(from Installatron)