Krystian Podemski Posted February 16, 2015 Share Posted February 16, 2015 (edited) Hello, I noticed that there is new version of validator so... 1. Where I can find the changelog? 2. What is the point of $this->name must have only alphanumeric characters ? Many themes module has prefix mod_ ph_ etc. Edited February 16, 2015 by Krystian Podemski (see edit history) 1 Link to comment Share on other sites More sharing options...
coeos.pro Posted February 16, 2015 Share Posted February 16, 2015 (edited) For the new version: - mod_ph_xxx become modPhXxx - the folders css, js and img are in the folder views that's what I could see last week, for modules (i only do modules, not themes.) Edited February 16, 2015 by coeos.pro (see edit history) Link to comment Share on other sites More sharing options...
jundinter Posted February 17, 2015 Share Posted February 17, 2015 Hello when trying to validate my module I get the following error: $this->name = 'MyModule' must have only alphanumeric characters This error didn't happen last week. Any idea? Thanks! Link to comment Share on other sites More sharing options...
coeos.pro Posted February 17, 2015 Share Posted February 17, 2015 I do not know when it changed, but Friday I updated a module and validating it I had some errors (new errors) now $this->version = '1.1'; is not accepted, , there must be: $this->version = '1.1.0'; Link to comment Share on other sites More sharing options...
Xavier du Tertre Posted February 17, 2015 Share Posted February 17, 2015 Hi, "_" underscores will be accepted again, soon Link to comment Share on other sites More sharing options...
shacker Posted February 26, 2015 Share Posted February 26, 2015 also why now all must be inside views? css, img, etc must recode all modules.... Link to comment Share on other sites More sharing options...
Tuni-Soft Posted February 26, 2015 Share Posted February 26, 2015 (edited) I can't find an explanation for the file Readme.md (required in the latest validation), what should it contain and where will the client view it? I filled it with markup from the module description on Addons website but i'm not sure where will it be viewed Edited February 26, 2015 by Tuni-Soft (see edit history) 1 Link to comment Share on other sites More sharing options...
shacker Posted February 27, 2015 Share Posted February 27, 2015 (edited) well, i dont understand why a theme must contains a index.php file in doc/ themes and modules, if you upload a theme , nobody can access to the zipped to browse directories Edited February 27, 2015 by shacker (see edit history) Link to comment Share on other sites More sharing options...
bellini13 Posted February 27, 2015 Share Posted February 27, 2015 (edited) I can't find an explanation for the file Readme.md (required in the latest validation), what should it contain and where will the client view it? I filled it with markup from the module description on Addons website but i'm not sure where will it be viewed look at the bankwire module included with the install package for an example. But I agree, again lack of documentation for validation rules. I continue to ask when these rules will be documented, and I always get 'soon'. Obviously my version of 'soon' and their version of 'soon' differ in definition... As does the enforcement of said rules. Download the latest Paypal Europe module v3.8.2 and try to run it through validator. Requirements: 1 red Structure: 68 red Errors: 7 red Optimizations: 40 red Licenses: 50 red Security: 80 red Standards: 60 red So once again the double standard applies. Only community modules need to pass validation, their own modules can be broken and fail validation but still be allowed through... Edited February 27, 2015 by bellini13 (see edit history) 5 Link to comment Share on other sites More sharing options...
Krystian Podemski Posted February 27, 2015 Author Share Posted February 27, 2015 I completely doesn't understand what is the point of having Readme.md for our modules, why now they move CSS to views/css/... ? It's nice that they make this tool because it helps in some cases, but some "standards" are just plain silly. Link to comment Share on other sites More sharing options...
bellini13 Posted February 27, 2015 Share Posted February 27, 2015 (edited) I don't care if they want to enforce rules so that all modules are consistent. I am sure they are setting up for some future version or feature by adding these changes. My issue is that they do not enforce their rules on all modules, and that makes having these rules completely pointless. Edited March 2, 2015 by bellini13 (see edit history) Link to comment Share on other sites More sharing options...
selectshop.at Posted February 28, 2015 Share Posted February 28, 2015 (edited) also why now all must be inside views? css, img, etc must recode all modules.... I think that the reason is that why it is easier to code for multishop features. Central for multishop-design is the them you are using. If you have several shops, each one with other theme, than it is clear that not modules, but theme has more flexibility for to have all separated. Edited February 28, 2015 by selectshop.at (see edit history) Link to comment Share on other sites More sharing options...
NemoPS Posted March 2, 2015 Share Posted March 2, 2015 Are there new coding standards as well? Would be great to see an update to that on github as well 1 Link to comment Share on other sites More sharing options...
sors Posted March 12, 2015 Share Posted March 12, 2015 Warning in function name upgrade_module_1_2_3 Link to comment Share on other sites More sharing options...
minic studio Posted April 21, 2015 Share Posted April 21, 2015 The whole addons becamed a joke! Link to comment Share on other sites More sharing options...
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now