benjamin utterback Posted December 13, 2012 Share Posted December 13, 2012 Hello PrestaShop Developers and Designers, PrestaShop has migrated to Github. We are very active on Github committing your pull requests. We appreciate all the support. If you have not used Github to make pull requests for PrestaShop, we would love to know why. Here is our Github Page: https://github.com/PrestaShop Here is our PrestaShop GitHub blogpost: http://www.prestasho...stashop-github/ Thank you so much for your feedback. Regards, Benjamin Link to comment Share on other sites More sharing options...
infoseek Posted December 15, 2012 Share Posted December 15, 2012 I think here most are users or merchants not develpoer, but to github is a very wise decision! Link to comment Share on other sites More sharing options...
benjamin utterback Posted December 17, 2012 Author Share Posted December 17, 2012 Hello infoseek, yes that is true. This poll was designed to poll the Designers and Developers. It is surprising that nobody has made any Pull Requests. I would appreciate any feedback as to why Developers and Designers are not making more Pull Requests. We have already made about 100 commits from our Community Members on GitHub to the new PrestaShop 1.5.3 Link to comment Share on other sites More sharing options...
HandCraft Posted December 18, 2012 Share Posted December 18, 2012 when 1.5.3 will be released??? Link to comment Share on other sites More sharing options...
benjamin utterback Posted December 18, 2012 Author Share Posted December 18, 2012 when 1.5.3 will be released??? Hello handcraft, 1.5.3 is scheduled to release this week or next. Are you a designer or developer? 2 Link to comment Share on other sites More sharing options...
HandCraft Posted December 19, 2012 Share Posted December 19, 2012 Thnx for the reply. I am shop owner. Hello handcraft, 1.5.3 is scheduled to release this week or next. Are you a designer or developer? Link to comment Share on other sites More sharing options...
HandCraft Posted December 19, 2012 Share Posted December 19, 2012 Where exactly will you declare once 1.5.3 is released????? Plz give the link....thnx Link to comment Share on other sites More sharing options...
benjamin utterback Posted December 19, 2012 Author Share Posted December 19, 2012 Hi Handcraft, when it is released there will be an announcement and the download will be ready. However, please stick to this topic about GitHub. Link to comment Share on other sites More sharing options...
PrestaShopDeveloper Posted December 19, 2012 Share Posted December 19, 2012 I suppose we should Pull Requests in the "development" branch - am I right? Link to comment Share on other sites More sharing options...
benjamin utterback Posted December 19, 2012 Author Share Posted December 19, 2012 Hi UltraWebDev, here is PrestaShop 1.5: https://github.com/PrestaShop/PrestaShop PrestaShop 1.5 Modules: https://github.com/PrestaShop/PrestaShop-modules PresatShop 1.4: https://github.com/PrestaShop/PrestaShop-1.4 Link to comment Share on other sites More sharing options...
PrestaShopDeveloper Posted December 19, 2012 Share Posted December 19, 2012 I got that. I even forked 1.5, but my question is in which "branch" we should Pull Request. Here's for example we have base repo (official one) and head repo (my fork). Which should be the "base/head branch"? Link to comment Share on other sites More sharing options...
benjamin utterback Posted December 19, 2012 Author Share Posted December 19, 2012 Hi UltraWebDev, sorry about that. All pull requests should be done in the Development Branch. Link to comment Share on other sites More sharing options...
SylRob Posted December 26, 2012 Share Posted December 26, 2012 (edited) /* Hi, I'm a developper and I must admit I don't know how to use github. If you want all developpers to follow you on github maybe you should help them by communicate about it: like what it is and how to use it */ maybe I spoke too fast cause I just found out this post http://www.prestashop.com/blog/en/what-need-know-prestashop-github/ Edited December 26, 2012 by SylRob (see edit history) Link to comment Share on other sites More sharing options...
SylRob Posted December 26, 2012 Share Posted December 26, 2012 Me again. I took 30 minutes to understand github, and I understood that it was quit complicated. we have to suscribe (I did), then download the software, install it, learn how tu use it (with its language), and then learn how to pull a request (and what it mean), a commit, the coding standards, how to understand a question or an answer etc... For somebody like me who didn't know about github, it stop me. In conclusion I would say that git hub is not for simple PHP developper like me. Link to comment Share on other sites More sharing options...
tdr170 Posted December 26, 2012 Share Posted December 26, 2012 Gihub is a great tool with one drawback that I am seeing fixes are being written to Github and don't seem to be making it to the Download version or the SVN versions. Here is an example, the Manufacturers page has the pagination, sorti section coded wrong in this Bug report (http://forge.prestashop.com/browse/PSCFV-5636) I posted the correct code and was told thanks it had been fixed on Github. As of today neither the SVN version or the Download version have this corrected. This should be corrected and known issues with 1.5.2 should be corrected and included in the current download & SVN. 1 Link to comment Share on other sites More sharing options...
benjamin utterback Posted January 8, 2013 Author Share Posted January 8, 2013 Hi Todd, when I downloaded 1.5.3.1 I did receive the updated manufacturer.tpl file. If there are any GitHub changes that are not yet placed in the download version please let me know, I will investigate and get back to you. Also, if anyone has completed any GitHub changes and are waiting to see if it will be committed and placed in PrestaShop download, let me know and I can try and expedite the process. Thank you guys! Link to comment Share on other sites More sharing options...
PhiLho Posted January 9, 2013 Share Posted January 9, 2013 (edited) if anyone has completed any GitHub changes and are waiting to see if it will be committed and placed in PrestaShop download, let me know and I can try and expedite the process. Good. I saw there are several pull requests waiting for being processed, some of them without even a comment. Your statement gave hope they will be processed some day... I made a small change for my usage which I shared in Import addresses with country as ISO code. If you find it useful enough for other people, I will make a pull request for it. Edited January 9, 2013 by PhiLho (see edit history) Link to comment Share on other sites More sharing options...
jd.creative Posted May 11, 2013 Share Posted May 11, 2013 As a designer, I should probably of used GitHub before... but I haven't... So I don't really know what any of it means, maybe I'll look into it soon. Link to comment Share on other sites More sharing options...
prestamax Posted August 18, 2013 Share Posted August 18, 2013 Great move. Does the github version replace the svn version? Link to comment Share on other sites More sharing options...
krisives Posted April 30, 2014 Share Posted April 30, 2014 I think one of the reasons you might not see as many pull requests is that you guys don't use the issue system, so linking to what issues are being solved by the PR is not as easy as other GitHub projects. Link to comment Share on other sites More sharing options...
benjamin utterback Posted April 30, 2014 Author Share Posted April 30, 2014 I think one of the reasons you might not see as many pull requests is that you guys don't use the issue system, so linking to what issues are being solved by the PR is not as easy as other GitHub projects. Hi! We use JIRA for an issue tracker. I agree that sometimes its hard to match up a GitHub commit with a Bug report, however we do our best to note it down. Link to comment Share on other sites More sharing options...
benjamin utterback Posted August 26, 2014 Author Share Posted August 26, 2014 Hey everyone, I noticed that many of you do not know how to submit a Pull Request for GitHub. Here is a guide that can help you, http://www.prestashop.com/blog/en/github-tutorial-with-prestashop/ I hope this helps. Thanks for voting! Link to comment Share on other sites More sharing options...
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now