Jump to content

LyoNick

Members
  • Posts

    13
  • Joined

  • Last visited

Profile Information

  • Activity
    User/Merchant

LyoNick's Achievements

Newbie

Newbie (1/14)

1

Reputation

  1. Hey NashControl, If you ever decide to submit it as SCCS, can you split it into partials as a single _file.css per model, and one rtl.scss that combine them all? this way it will be much easier to maintain and modify? also this way it can be done in incremental steps. Thank you any way. Lyo
  2. thank you for the very detailed replays i will take a closer look as soon as i got some time. it looks like you are making a lot of progress already! Lyo
  3. i have tried adding a file named maintenance_rt.css and clearing cache but it seems the maintenance.tpl still load maintenance.css and not maintenance_rt.css what am i missing? ​edit: well this page have no controller, hence no addCSS() i tried with sitemap.css and it indeed load sitemap_rtl.css
  4. this is gr8! so basically all i need is to create one file_rtl.css at the time? should i create a new scss file? or are you using something like http://anasnakawa.github.io/bi-app-sass/ to auto generate them? do you have a road-map for the RTL supports? whats is done whats still need to be done and ETA? where can i help? one last thing: what is your solution for loading an horizontal flipped image when appropriate? i will check your unofficial site now.
  5. after initial search i found this - http://stackoverflow.com/questions/14199323/right-to-left-rtl-support-in-sass-project and that led me to this: http://anasnakawa.github.io/bi-app-sass/ so it seems to (the un-experience) me like a conditional '_THEME_CSS_DIR_' can be a better approach. any thought? Lyo
  6. ok! so after we clear that up, i guess for now we are going forward with the current choice using rtl.css to override when needed. just to sum it up: ALL the RTL fixes should be in the rtl.scss / rtl.css right? not separated to specific file per module? i'll start playing around as soon as i'll find some time. any pointers will be appreciated. ------------------------------------------------------- the reason i thought to made a different theme is due to the fact that some images need to flip side, some fonts might be changed and maybe (not sure yet) even bootstrap itself need a bootstrap_rtl version, making the theme a lot different. but since most of the changes are in the css: maybe we can just conditionally change the constant '_THEME_CSS_DIR_' to point to a new folder 'css_rtl' instead of 'css' when the is_rtl flag is set? reusing almost all the other assets. it will also clean the code from re-checking for RTL everywhere, i.e like the snippet you pointed out and reloading in the footer. i am new to sass and compass, so i am going to look for a way to generate 2 css versions conditionally from the same source, making the work even less a duplicate. but this will require some research. Lyo
  7. 1. where in the DB the RTL setting is set? 2. how can we check this setting from PHP? 3. how can we check this setting from smarty? 4. how can we check this setting from js? 5. what currently make the page aware the rtl css version is needed? 6. how early can we test for it while loading of the shop? 7. what were the reasons to choose overwriting everything with rtl.css? 8. what were the reasons if any AGAINST simply checking if is RTL lang and change the css path from /css to /css_rtl? (this will also simplify the getCSSPath function @ classes/Media.php) 9. why those reason do not apply to the mobile theme (use condition in the defines_uri.inc.php, and FrontController.php files)? 10. i think it will be much easier to simply make the RTL a separate theme like the mobile. am i wrong? why? 11. i also think it will benefit other none-RTL multi-languages stores to have an OPTION to use different themes for different languages. separating the RTL theme issue and making it contained and incrementally solvable, one sass file at the time. please be as critic as you can, helping me understand those choices and start to work with them, OR we can start moving toward the separation and solve it in bite size chunks Lyo edit: for unknown reason some of the text is larger and bolder, ignore it.
  8. הודות למתנדבים רבים (ובמיוחד לתומר שתרגם כמעט לבדו את 15% האחרונים https://crowdin.com/profile/TOMER628 ( התרגום הראשוני לגרסאות 1.6.0.9 ו 1.6.0.10 הושלם עדיין ישנם בעיות איכות בתרגום לכן נוכל להיעזר בהצעות חילופיות למשפטים שמתורגמים גרוע המודול שהכי זקוק לתרגום משופר הוא referralprogram https://crowdin.com/translate/prestashop-official/32094/en-he שמלא בחוסר עקביות ותרגומים שאינם באמת תואמים כל הצעה לתרגום חילופי תתקבל בברכה ניתן לעדכן את חנותכם לתרגום האחרון דרך ממשק הניהול של החנות !! בצעו גיבוי לפני!! מומלץ לבצע בדיקה על חנות לוקלית אוף ליין שנה טובה לכולם! ליאו
  9. in csv import combination and addresses are missing the 'Force all ID numbers' switch 1) is it default to force or to not force? 2) why no switch? is it a bug or intentional? our use case: we are keeping small CSV files for each group, category etc, in addition to a full csv per type so when importing to a different shop, or re-importing it can be done in bite size. making it easy to audit, and also give as ability to easly pick and choose what we don't wont to import, and some time pulling in information from other sources and re-importing a small subset. hence we relay quit heavily on the 'Force all ID numbers' to keep the relation consistent in the DB
  10. thank you for sharing it via github i am hoping to test it on a clean shop next week and a full local instance of a shop the week after, if i'll have anything to suggest after, it will be via github Thank's a lot Lyo
  11. split them to 2 separated files, e.g Product-EN.csv & Product-LT.csv KEEP the ID the same!! make sure everything has an ID import both, make sure to TURN OFF 'delete all product before import' good luck.
  12. למישהו יש מושג איך לתרגם את: Live Configurator ?
  13. השלמתי את רוב התרגום לעברית עבור גירסה 1.6.0.9 ניתן לצפות בו באתר https://crowdin.net/project/prestashop-official/he#/1.6.0.9 כל מי שיכול שיצטרף, לתרגם את החלקים שנותרו ולתקן את הקיים חלקים רבים ממנו הם שאריות מגרסאות קודמות וכל עין נוספת תועיל הערות התקבלו בברכה בנושאים: המלצת תרגום שגיאות כתיב שגיאות בתרגום הצעת תרגום עדיף וכו' גירסה 1.6.0.9 אמורה להשתחרר בימים הקרובים, כך שמומלץ לסיים לפחות את תרגום קבצי הבסיס לפני השחרור במיוחד את הקובץ: email_contents הקבצים: install admin פחות חשובים כי אינם מול הלקוחות ואת שאר קבצי הבסיס השלמתי גם את רוב קבצי המודולים השלמתי, אך שם סדר העדיפות הוא יותר אישי.
×
×
  • Create New...